I agree with Adam,
I think an Exception while calling any of the methods on ValueBinding
(except for the setValue method) should be considered a bug in the
application and logged at
level WARNING.

And in this case, we should return true
to indicate that the binding is readOnly (opt for the more restrictive
option when there are errors).

--arjuna


On 10/6/06, Adam Winer <[EMAIL PROTECTED]> wrote:

Martin,

Looking at this bug and patch, I'm not sure of the right way to go.

I'm worried about this;  if the exception is thrown constantly, that
could be a significant performance problem.  I'm not at all sure that
we wouldn't want to warn the developer (hence, _LOG.warning()).  Also,
maybe returning true would be better than false here, since the value
isn't writable.

If we do catch the exception, what happens later when the value is
actually retrieved for rendering?  Isn't that just going to generate
another uncaught exception?

-- Adam

Reply via email to