Yeah sorry, I didn't notice the comment either. I updates the JIRA
ticket. You're correct Adam, and I need some advice on the ticket if
you could.
Jeanne Waldman wrote:
Adam,
I just noticed this email. I'll ping Scott.
- Jeanne
Adam Winer wrote:
Has this change been tested? I'm far from certain
that this was purely an optimization. We often
check whether there is a PartialPageContext to
see if PPR is enabled, and if this check is removed,
then a lot of code will (I think) assume that PPR
is enabled and available when it is not.
-- Adam
On 1/25/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: jwaldman
Date: Thu Jan 25 14:02:08 2007
New Revision: 500011
URL: http://svn.apache.org/viewvc?view=rev&rev=500011
Log:
ADFFACES-364 PartialPageContext optimization bug. Check in for Scoot
O'Bryan to jwaldman-portal branch.
Remove this optimization in _initializePPR:
// Don't bother if PPR isn't even supported
if (!CoreRendererUtils.supportsPartialRendering(this))
return;
The reason is commented in the code:
//There used to be an optimization here which would simply
return when
//the PartialRendering capabilities were disabled. This was
removed
//because it is possible for extensions to Trinidad to support
PPR in a
//container-specific way in a Portal Environment even though
such capability
//is off by default. Furthermore, the check on whether
something is a
//PPR request or not is very efficient, so there is very little
time saved
//by the optimization.
Modified:
incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
Modified:
incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
URL:
http://svn.apache.org/viewvc/incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java?view=diff&rev=500011&r1=500010&r2=500011
==============================================================================
---
incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
(original)
+++
incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
Thu Jan 25 14:02:08 2007
@@ -466,9 +466,13 @@
FacesContext fContext,
RequestContext context)
{
- // Don't bother if PPR isn't even supported
- if (!CoreRendererUtils.supportsPartialRendering(this))
- return;
+ //There used to be an optimization here which would simply
return when
+ //the PartialRendering capabilities were disabled. This was
removed
+ //because it is possible for extensions to Trinidad to support
PPR in a
+ //container-specific way in a Portal Environment even though
such capability
+ //is off by default. Furthermore, the check on whether
something is a
+ //PPR request or not is very efficient, so there is very little
time saved
+ //by the optimization.
PartialPageContext partialPageContext =
PartialPageUtils.createPartialPageContext(fContext,
