Currently, the VM arguments are added as one single command-line parameter 
to the DevAppServer launch. This causes problems when you want to add 
multiple, separate arguments to the run configuration.

For example, I wanted to move the local Datastore and Blobstore out of the 
/build/exploded-app folders so they would be retained between two runs. I 
set the following as VM args in my DevAppServer confiugration:

-Dblobstore.backing_store=path/to/blobstore 
-Ddatastore.backing_store=path/to/local_db.bin

However when I ran this, the command looks like this:

java 
-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:53043,suspend=y,server=n 
*"-Dblobstore.backing_store=path/to/blobstore 
-Ddatastore.backing_store=path/to/local_db.bin"* -javaagent:[...snipped]

Notice that the quotes are around *both* arguments, which leads to them not 
being properly recognized. I managed to find the source of the problem 
(line 213 in 
AppEngineRunConfiguration<https://android.googlesource.com/platform/tools/studio/cloud/+/0ad430cfb17f15a66644039a15393c6cc642c0d1/src/com/google/gct/idea/appengine/run/AppEngineRunConfiguration.java>)
 
and fixed it so it correctly puts the arguments *separately *on the command 
line:

java 
-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:53043,suspend=y,server=n 
*"-Dblobstore.backing_store=path/to/blobstore" 
"-Ddatastore.backing_store=path/to/local_db.bin"* -javaagent:[...snipped]

This is my first contribution to AOSP, so I'm not sure I'm doing everything 
correctly. I created the fix, tested it locally by building Android Studio 
from the AOSP sources and it works fine. I submitted a patch a few days 
ago<https://android-review.googlesource.com/91590/>, 
but it seems like it hasn't been looked at yet. Do I need to add reviewers 
myself or something? And if so, who should I add? Who is working on the 
Google Cloud Tools in Android Studio?

-- 
You received this message because you are subscribed to the Google Groups 
"adt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to