Thanks Xavier, sorry for that. Indeed when not consuming PROVIDED and TESTED_CODE the duplicates go away. Thanks! Ariel
On Sunday, November 22, 2015 at 9:20:00 PM UTC+2, Xavier Ducrohet wrote: > > You're consuming PROVIDED and TESTED_CODE? you shouldn't do that. I'm also > not showing it in your output so that's a problem. These should not be > touched, they should be referenced only. > > We'll put some enforcement for this. > > On Sun, Nov 22, 2015 at 3:34 AM, Ariel Cattan <[email protected] > <javascript:>> wrote: > >> Hi Xavier, >> >> Here are the details: >> >> Consumed scopes - I'm consuming all scopes: >> QualifiedContent.Scope.PROJECT >> QualifiedContent.Scope.PROJECT_LOCAL_DEPS >> QualifiedContent.Scope.SUB_PROJECTS >> QualifiedContent.Scope.SUB_PROJECTS_LOCAL_DEPS >> QualifiedContent.Scope.EXTERNAL_LIBRARIES >> QualifiedContent.Scope.PROVIDED_ONLY >> QualifiedContent.Scope.TESTED_CODE >> >> Referenced scopes - none. >> >> Input and Output types: QualifiedContent.DefaultContentType.CLASSES >> >> I am creating an output per scope in jar format. In practice in my >> project the transform creates the following jars: >> >> >> ...\build\intermediates\transforms\safedkWrap\demo\release\jars\1\1\PROJECT.jar >> >> ...\build\intermediates\transforms\safedkWrap\demo\release\jars\1\10\EXTERNAL_LIBRARIES.jar >> >> ...\build\intermediates\transforms\safedkWrap\demo\release\jars\1\2\PROJECT_LOCAL_DEPS.jar >> >> ...\build\intermediates\transforms\safedkWrap\demo\release\jars\1\4\SUB_PROJECTS.jar >> >> ...\build\intermediates\transforms\safedkWrap\demo\release\jars\1\1\PROJECT.jar >> >> And yes, I'm creating a jar for all inputs, including the directory >> inputs of the project. >> I checked, and there are no duplicate classes inside these jars. >> >> Thanks! >> Ariel >> >> >> On Thursday, November 19, 2015 at 9:52:04 PM UTC+2, Xavier Ducrohet wrote: >>> >>> Can you describe your custom transform? I tried it on a regular project >>> and didn't see this duplication of inputs like you do. >>> >>> Can you provide: >>> - the consumed/referenced scopes >>> - the content types (input/outputs) >>> >>> How you create the outputs (one per scope?). It looks like you're >>> creating jars for all the inputs, even the directory input of the project? >>> >>> I'm going to try to create a fake transform (no actual transform, just >>> copy the inputs in the output) and see if I can reproduce. >>> >>> thanks >>> >>> On Mon, Nov 16, 2015 at 2:56 AM, Ariel Cattan <[email protected]> wrote: >>> >>>> Hi Xavier, >>>> >>>> I would like to report that in addition to the proguard errors >>>> mentioned before, now with 1.5.0, when I apply my Transform, Proguard >>>> prints tons of "duplicate definition of library class" errors. It seems >>>> that for some reason it reads every output of the transform twice. >>>> My transform generates one jar per scope as follows: >>>> >>>> >>>> D:\AndroidStudioProjects\test2\build\intermediates\transforms\safedkWrap\demo\release\jars\1\1\PROJECT.jar >>>> >>>> D:\AndroidStudioProjects\test2\build\intermediates\transforms\safedkWrap\demo\release\jars\1\10\EXTERNAL_LIBRARIES.jar >>>> >>>> D:\AndroidStudioProjects\test2\build\intermediates\transforms\safedkWrap\demo\release\jars\1\2\PROJECT_LOCAL_DEPS.jar >>>> >>>> D:\AndroidStudioProjects\test2\build\intermediates\transforms\safedkWrap\demo\release\jars\1\4\SUB_PROJECTS.jar >>>> >>>> But then when proguard runs I can see in the build log that for each of >>>> the above it prints "Reading program jar", and later prints "Reading >>>> library jar" with the same jar name. Maybe this can serve as a hint where >>>> to look for the problem. >>>> >>>> I'm attaching two build outputs: >>>> 1. proguard.txt - gradle output when running a release build without >>>> our transformation. Even without us you can see some proguard errors >>>> inside. >>>> 2. proguard-with-transform.txt - this time with our transform. You can >>>> see in there the tons of "duplicates" I described above. >>>> >>>> I hope this can be fixed soon, as it prevents us from supporting 1.5.0 >>>> in our plugin, which forces our customers to stick to 1.3.1. >>>> >>>> Thanks! >>>> Ariel >>>> >>>> >>>> On Thursday, November 12, 2015 at 7:19:51 PM UTC+2, Csaba Kozák wrote: >>>>> >>>>> Thanks. I am looking forward for the fix. >>>>> >>>>> I am also using the com.google.gms:google-services:1.5.0 plugin. >>>>> I have to downgrade both the Android Gradle plugin and the Google >>>>> Services plugin to get rid of the warnings. >>>>> I guess the GMS plugin forced to use the 1.5.0 builder or so that is >>>>> why i was still getting those. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "adt-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Xavier Ducrohet >>> Android SDK Tech Lead >>> Google Inc. >>> http://developer.android.com | http://tools.android.com >>> >>> Please do not send me questions directly. Thanks! >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "adt-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Xavier Ducrohet > Android SDK Tech Lead > Google Inc. > http://developer.android.com | http://tools.android.com > > Please do not send me questions directly. Thanks! > -- You received this message because you are subscribed to the Google Groups "adt-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
