On Thu, Feb 14, 2013 at 10:44:49AM -0500, John Eckersberg wrote: > We're still running on the 3.2.12-ish stack that I put in after the > first round of security holes came through. There's been several more > rounds and probably more to come, so we need to keep pulling in updates. > I just took a brief stab at updating to 3.2.12 proper, and a bunch of > tests exploded as usual. I don't have time at the moment to bang on it > myself, so if anybody wants to jump on it, you can be a hero.
I've got a pull request sent for this now: https://github.com/aeolusproject/conductor/pull/404 (Hopefully you can find it, despite the number...) It was a bit of an adventure. 3.2.12 was a security-only fix, so it also included the bugs we were seeing in 3.2.11. So I then advanced to the tip of their 3-2-stable branch, but this commit was causing issues: https://github.com/rails/rails/commit/c5451777b038c5e48567f69256986ae42a2cde48 Thanks to Jan for helping to debug that one. We got it rolled back upstream, so I was able to move us up to the head of their 3-2-stable branch, getting both the fix for habtm and the security patches that formed 3.2.12. A recent patch in between these versions apparently caused Mailer to raise an exception if we didn't set a :from on outgoing mail, which we were only doing in test, so I set it in environments/test.rb even though mail is not actually being delivered... And now all tests should be green. -- Matt
