> On 6/30/05, David Zülke <[EMAIL PROTECTED]> wrote: > > I implemented the pluggable ExecutionFilter in it's own branch. It's > working > > nicely, I even wrote the first replacement ExecutionFilter for a project > ;) > > > > The filter that is to be used has to be defined in factories.ini: > > > > execution_filter = "ExecutionFilter" > > > > Everything else is as before the changes. > > > > If anyone wants to change this - it's welcome. I'd like to merge this > > tonight if nobody has objections. > > Objection! :) > > I cant speak for everyone but I barely had a chance to receive your > notice, let alone read it and go see what your changes entailed. I'm > as guilty as anyone about merging in haste to trunk as I dont think my > last merges were done with any more patience, but I believe I will > from now on. :) I think after a day's notice or a majority of the devs > have come back without reservations, whichever happens first is > probably a good idea.
Yeah, I really was way too quick there. Sorry for that. > For the record, we use trunk in a number of places and so we do our > best to maintain it's stability. As a show of faith in this stability, > we run agavi.org on a checked out copy of trunk as well which is > periodically synced up. So, if for no other reason that this... Allow > for sufficient time for the other devs to eval what's going on before > any merging into trunk. > This is the main motivation to having everyone do their development in > a branch in the first place. I've updated the wiki to emphasis this a > little better. Yeah, I think you're right ;) > About the changeset.. http://trac.agavi.org/trac.cgi/changeset/157 > You should be able to instantiate the ExecutionFilter and initialize > it, the same as is done with the security filter and it wouldnt be > misleading as I would expect $this->executionFilter to be the actual > object. I can rename the variable if you like. However, I don't want to use one instance for all filters. It used to be $execFilter = new ExecutionFilter(); And would now be $execFilter = new $this->executionFilterClass(); I think this might have a reason. And I can imagine situations where people with CustomExecutionFilters would need separate instances for every call. I'm sure there is a reason why Sean back then decided to use a new instance each time, so why should we change that? > -Mike > PS: David, I love you. :) I love you too, Mike ;) - David _______________________________________________ agavi-dev mailing list [email protected] http://labworkz.com/cgi-bin/mailman/listinfo/agavi-dev
