Yes, right. The config setup now works fine. I looked through today I think the thing to do is set configs/defs.inc to configs/defs.php and then make those set, but allow for them to be defined in config.php as an override.
The config.php the installers generate ideally should be super minimal like they are from the libs/installer.php you made. The other things, I will just execute on. Jon On Sun, Jan 8, 2012 at 10:18 PM, Bassel Safadi <[email protected]> wrote: > one thing though is that we can't connect to database without a config file > being written to store the database connection information. one solution > could be writing them inside a sqlite db file. but that will require users > to have sqlite installed which add more complexity. users are used to config > files that need to be created manulay since all web apps require this > > -- > Bassel Safadi | http://bassel.ws > Skype: i.know.sy | Global: +1-323-545-3855 > > > > On Fri, Jan 6, 2012 at 1:15 PM, Jon Phillips <[email protected]> wrote: >> >> Hahaha, I cheated a bit on getting to 1000 on aiki :) Congrats to us! >> >> Ok, Bassel was being too slow for me, so I fixed some of the misplaced >> things left from his radical changes. >> >> I re-added the phpunit directory called tests. Check inside that >> folder, I updated the tests/README with instructions on how to write >> php unit tests for code. >> >> Also, I cleaned up a few parts in the text files. >> >> No one has replied on the licensing thread, so we are clear. It has >> bothered me for some time that licensing is included in every file. I >> would much prefer to just include in one file: Aiki Framework ✳ Aiki >> Lab Pte Ltd and AUTHORS (✳ = http://sharism.org/agreement) Should that >> be in the README, or in the LICENSE file. I would prefer just remove >> that requirement. If we need to be compliant with some copyright >> declaration per file, then we can replace all teh AGPL declaration >> text and go for the more liberal release of all copyright Sharing >> Agreement with the text above. >> >> As for the configs/defs.inc I brought that back because there are >> defaults that used to be defined by the build process. Now, these are >> not being defined. Bassel and others, what is the best way to define >> these defaults? Ideally, these defaults would be defined by the web >> installer. Also, ideally, the web installer would define configuration >> options saved in the database, so that a config.php NEVER would have >> to be generated. Then, one could drop in their own config.php as a >> backup option. What do you all think about this? >> >> I think since we are targeting normal people, we should try to not >> have to set defaults that are confusing, but offer an option/advanced >> panel that can be exposed so more advanced users can set some >> defaults. What do you all think about this? >> >> I would like to hear thoughts before proceeding. >> >> So right now we have these sets of options: >> >> * configs/config.php >> * configs/defs.inc >> >> config.php is supposed to be the default configuration options for an >> installation. Defs are supposed to be defined constants, that really >> should not be changed. Also, there are many defined constants from >> fosdevel's partially complete web-based updater solution. With the old >> build process configs/defs.inc was to be converted to configs/defs.php >> which is read by the configs/config.php >> >> So, what to do? Here are some options: >> >> * add to the installer to define the constants and generate a >> configs/defs.php or defs.php at the aiki installation root. The >> problem is it requires write access to the configs folder. That could >> be a stumbling block. >> >> * preset the defs.inc defines to sensible default and/or empty paths >> which can assume since they aren't set, they don't exist, so feature >> is turned off. The problem with this is we don't know peoples setups, >> so this is headed for more bug reports. >> >> * convert the defines to configuration options so their existence is >> checked in the config.php or configs/config.php first, and if not >> there, then in the database >> >> Overall configuration setup for the future. >> >> If we are to make aiki simple for humans I think we need to make sure >> that the web installer write configurations to the database and a >> config.php is not written by default to >> AIKI_INSTALLATION_PATH/config.php. That would be great to remove one >> more stumbling block. This way, if there is some problem on one's >> setup, a config.php could be written and placed at >> AIKI_INSTALLATION_PATH/config.php to override the defaults in the >> database. >> >> As for the constants in defs.inc, we can set some of those with the >> web installer, and some of them look like they should be stored in the >> database. >> >> Sorry if this is confusing, trying to get a consensus. >> >> Jon >> >> >> >> -- >> Jon Phillips 王✳爻气 http://fabricatorz.com ✳ skype: kidproto ✳ irc: rejon >> +1.415.830.3884 (global) ✳ +86-187-1003-9974 (beijing) > > -- Jon Phillips 王✳爻气 http://fabricatorz.com ✳ skype: kidproto ✳ irc: rejon +1.415.830.3884 (global) ✳ +86-187-1003-9974 (beijing) _______________________________________________ Mailing list: https://launchpad.net/~aikiframework-devel Post to : [email protected] Unsubscribe : https://launchpad.net/~aikiframework-devel More help : https://help.launchpad.net/ListHelp
