** Changed in: aikiframework
Status: Confirmed => Fix Released
--
bare strings without CSS ids in code buhao!
https://bugs.launchpad.net/bugs/678383
You received this bug notification because you are a member of Open Font
Library Developers, which is subscribed to Open Font Library.
Status in Aiki Framework: Fix Released
Status in openclipart: Confirmed
Status in Open Font Library: Confirmed
Bug description:
This is horrible. The default error messages in aiki are being output without
any ID for styling with CSS or class, and more importantly bare strings have no
ability to be translated. This is totally bad form.
An example of this is all over aiki/src/system/libraries/records.php
Just do a search for the variable being used to spread this heinous practice:
re...@futurebox:~/Documents/aikiframework/aikiframework/src/system/libraries$
grep -Rn "output_result" *
records.php:136: $output_result = "";
records.php:209: $output_result .= "__warning__
Please fill $intwalker[1]<br />";
records.php:235:
$output_result .= "<b>Please enter a password</b><br />";
records.php:278:
$output_result .= "<b>The email address is not valid</b><br />";
records.php:295:
$output_result .= "<b>This value is already in use</b><br />";
records.php:446:
$output_result .= "new directory created: $path";
records.php:457: $output_result
.=( "Sorry, but that file '$newfile' already exists.");
records.php:573: $output_result .=
"__added_successfully__<br />";
records.php:576: $output_result .=
"uploaded <b>$num_of_uploaded_files</b> files out of
<b>$total_uploaded_files</b> selected files<br /><br />";
records.php:577: $output_result .=
"<b>Uploaded files:</b><br />".$files_names_output;
records.php:581: $output_result .= "<br
/><b>NOT uploaded files:</b><br />".$not_uploaded_output;
records.php:618: $output_result .=
"Filename:<br />";
records.php:619: $output_result .= "<p
dir='ltr'>".$name."</p>";
records.php:622: $output_result =
"__error_inserting_into_database__<br>";
records.php:623: $output_result .= "Nothing
uploaded <br />";
records.php:625: $output_result .= "<br
/><b>NOT uploaded files:</b><br />".$not_uploaded_output;
records.php:688: return $output_result;
records.php:908: $output_result =
"Edited record $record_id in $tablename successfully";
records.php:912: $output_result =
"Inserted new record in $tablename successfully";
records.php:918: $output_result = "Faild to edit record
$record_id in $tablename";
records.php:921: return $output_result;
We need a solution to this that is translatable. Ideally, all error output that
is nonessential would be in aiki, then if not in aiki, it needs to use GETTEXT
to generate language.
Steps to fixing this bug:
1.) figure out our best solution
2.) scour the codebase and apply the fix
The problem right now is that default error messages on ocal, scale, and other
sites just pop up. An immediate solution is to style these with a class like
message or error or warning depending upon severity. bassel, we need to talk
this one out.
_______________________________________________
Mailing list: https://launchpad.net/~aikiframework.admins
Post to : aikiframework.admins@lists.launchpad.net
Unsubscribe : https://launchpad.net/~aikiframework.admins
More help : https://help.launchpad.net/ListHelp
