>From the source: "Only change this if you're very confident and lucky" :-)
On Thu, Mar 31, 2016 at 9:30 AM, Endre Varga <endre.va...@lightbend.com> wrote: > Shouldn't we all postStop there if preStart has been at least invoked > (i.e. there is already an instance)? It does not seem to be hard, just > shuffling that code a bit around (famous last words?). > > On Thu, Mar 31, 2016 at 9:25 AM, Patrik Nordwall < > patrik.nordw...@gmail.com> wrote: > >> I think that is how it is implemented. Exception from preStart results in >> clearing the actor field and throwing ActorInitializationException: >> >> https://github.com/akka/akka/blob/master/akka-actor/src/main/scala/akka/actor/ActorCell.scala#L599 >> >> Default supervision will result in stop, but postStop is not called >> because the actor field was cleared: >> https://github.com/akka/akka/blob/master/akka-actor/src/main/scala/akka/actor/dungeon/FaultHandling.scala#L210 >> >> On Wed, Mar 30, 2016 at 10:59 AM, Endre Varga <endre.va...@lightbend.com> >> wrote: >> >>> >>> >>> On Sun, Mar 27, 2016 at 5:52 PM, Stanislav Savulchik < >>> s.savulc...@gmail.com> wrote: >>> >>>> Hi, everyone! >>>> >>>> I've discovered that Actor's postStop method doesn't get invoked if >>>> exception occurs during actor initialization via preStart method. Does >>>> anyone know if it is the correct behavior? I expected that the failed actor >>>> could close some resources in postStop. >>>> >>> >>> Do you have a reproducer for this? I would also expect postStop to be at >>> least attempted to be called. >>> >>> >>>> P.S. The behavior differs when a failure occurs during regular vs. >>>> system message processing and supervisor decides to Stop the failed child. >>>> It seems inconsistent to me. >>>> >>> >>> What do you mean here? Can you provide a small example to show this? >>> >>> >>>> -- >>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>> >>>>>>>>>> Check the FAQ: >>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>> >>>>>>>>>> Search the archives: >>>> https://groups.google.com/group/akka-user >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "Akka User List" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to akka-user+unsubscr...@googlegroups.com. >>>> To post to this group, send email to akka-user@googlegroups.com. >>>> Visit this group at https://groups.google.com/group/akka-user. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>> >>>>>>>>>> Check the FAQ: >>> http://doc.akka.io/docs/akka/current/additional/faq.html >>> >>>>>>>>>> Search the archives: >>> https://groups.google.com/group/akka-user >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Akka User List" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to akka-user+unsubscr...@googlegroups.com. >>> To post to this group, send email to akka-user@googlegroups.com. >>> Visit this group at https://groups.google.com/group/akka-user. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> >> Patrik Nordwall >> Akka Tech Lead >> Lightbend <http://www.lightbend.com/> - Reactive apps on the JVM >> Twitter: @patriknw >> >> [image: Lightbend] <http://www.lightbend.com/> >> >> -- >> >>>>>>>>>> Read the docs: http://akka.io/docs/ >> >>>>>>>>>> Check the FAQ: >> http://doc.akka.io/docs/akka/current/additional/faq.html >> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user >> --- >> You received this message because you are subscribed to the Google Groups >> "Akka User List" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to akka-user+unsubscr...@googlegroups.com. >> To post to this group, send email to akka-user@googlegroups.com. >> Visit this group at https://groups.google.com/group/akka-user. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ > >>>>>>>>>> Check the FAQ: > http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > --- > You received this message because you are subscribed to the Google Groups > "Akka User List" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to akka-user+unsubscr...@googlegroups.com. > To post to this group, send email to akka-user@googlegroups.com. > Visit this group at https://groups.google.com/group/akka-user. > For more options, visit https://groups.google.com/d/optout. > -- Patrik Nordwall Akka Tech Lead Lightbend <http://www.lightbend.com/> - Reactive apps on the JVM Twitter: @patriknw [image: Lightbend] <http://www.lightbend.com/> -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to akka-user+unsubscr...@googlegroups.com. To post to this group, send email to akka-user@googlegroups.com. Visit this group at https://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
