Thanks for reporting., Fixed, will be in upcoming 2.4.10 /Patrik tors 1 sep. 2016 kl. 20:58 skrev Moax76 <morten.kjetl...@gmail.com>:
> Issue created: https://github.com/akka/akka/issues/21343 > > But I'll modify my serializer anyway. > > Thanks. > > -Morten > > > On Thursday, September 1, 2016 at 8:33:04 PM UTC+2, Patrik Nordwall wrote: > >> I think we should handle exceptions from serializer.toBinary as transient. >> Can you please create an issue. <https://github.com/akka/akka/issues/new> I >> can understand that the reason might be that it is a program bug and the >> system should probably not run with the bug, but I think error logging >> should be enough since the exception doesn't result in any undefined state. >> >> Deserialization is a another story, which is exhausted in that ticket >> Martynas linked to. >> > >> On Thu, Sep 1, 2016 at 7:46 PM, Moax76 <morten....@gmail.com> wrote: >> >>> Thanks a lot for the info. >>> >>> I'll fix my serializer so that it wraps all exceptions >>> in NotSerializableException. >>> Am I understanding it correct that I should only do this wrapping when >>> serializing, and not deserializing? >>> >>> Thanks again. >>> >>> -Morten >>> >>> On Thursday, September 1, 2016 at 4:14:43 PM UTC+2, drewhk wrote: >>>> >>>> The only reason serialization errors cause a connection to be dropped >>>> if the *deserialization* fails. This is because TCP is a streaming protocol >>>> and we cannot decide why the deserialization failed, because of some bug, >>>> or the TCP framing is out of sync. We just drop the connection to start >>>> from a clean state. >>>> >>>> -Endre >>>> >>>> On Thu, Sep 1, 2016 at 3:33 PM, Martynas Mickevičius < >>>> martynas.m...@lightbend.com> wrote: >>>> >>>>> EndpointWriter is only treating NotSerializableException as a >>>>> transient one. So wrapping all of the exceptions from your serializer >>>>> into NotSerializableException will not get the association dropped. >>>>> >>>>> Here is the discussion on having all of the exceptions transient: >>>>> https://github.com/akka/akka/issues/20641 >>>>> >>>>> On Wed, Aug 31, 2016 at 4:56 PM, Viktor Klang <viktor...@gmail.com> >>>>> wrote: >>>>> >>>>>> Well, I agree that it shouldn't gate the connection due to a failure >>>>>> to serialize. >>>>>> >>>>>> Do you have a minimal reproducer to share? >>>>>> >>>>>> On Wed, Aug 31, 2016 at 3:48 PM, Moax76 <morten....@gmail.com> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Wednesday, August 31, 2016 at 3:37:41 PM UTC+2, √ wrote: >>>>>>>> >>>>>>>> What happens if you fix the serializer? >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> If I fix the serializer, then the problem off course goes away, but >>>>>>> that is not the point. >>>>>>> >>>>>>> The problem is that instead of dropping the message that (for some >>>>>>> 'unknown' reason) failed to be serialized, it "drops" the connection, >>>>>>> and >>>>>>> GATES it so that it will not try to reconnect in 5 seconds. >>>>>>> >>>>>>> If it worked as described above, this serializing issue would be a >>>>>>> regular bug the only effected parts of the application, instead of the >>>>>>> entire application going "down" due to cluster-issues. >>>>>>> >>>>>>> >>>>>>> -Morten >>>>>>> >>>>>>> -- >>>>>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>> >>>>>>>>>> Check the FAQ: >>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>> >>>>>>>>>> Search the archives: >>>>>>> https://groups.google.com/group/akka-user >>>>>>> --- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Akka User List" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to akka-user+...@googlegroups.com. >>>>>>> To post to this group, send email to akka...@googlegroups.com. >>>>>>> Visit this group at https://groups.google.com/group/akka-user. >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Cheers, >>>>>> √ >>>>>> >>>>>> -- >>>>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>> >>>>>>>>>> Check the FAQ: >>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>> >>>>>>>>>> Search the archives: >>>>>> https://groups.google.com/group/akka-user >>>>>> --- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Akka User List" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to akka-user+...@googlegroups.com. >>>>>> To post to this group, send email to akka...@googlegroups.com. >>>>>> Visit this group at https://groups.google.com/group/akka-user. >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> >>>>> -- >>>>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>> >>>>>>>>>> Check the FAQ: >>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>> >>>>>>>>>> Search the archives: >>>>> https://groups.google.com/group/akka-user >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Akka User List" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to akka-user+...@googlegroups.com. >>>>> To post to this group, send email to akka...@googlegroups.com. >>>>> Visit this group at https://groups.google.com/group/akka-user. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> >>>>>>>>>> Read the docs: http://akka.io/docs/ >>> >>>>>>>>>> Check the FAQ: >>> http://doc.akka.io/docs/akka/current/additional/faq.html >>> >>>>>>>>>> Search the archives: >>> https://groups.google.com/group/akka-user >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Akka User List" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to akka-user+...@googlegroups.com. >>> To post to this group, send email to akka...@googlegroups.com. >>> Visit this group at https://groups.google.com/group/akka-user. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> > Patrik Nordwall >> Akka Tech Lead >> > Lightbend <http://www.lightbend.com/> - Reactive apps on the JVM >> Twitter: @patriknw >> > -- > >>>>>>>>>> Read the docs: http://akka.io/docs/ > >>>>>>>>>> Check the FAQ: > http://doc.akka.io/docs/akka/current/additional/faq.html > >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user > --- > You received this message because you are subscribed to the Google Groups > "Akka User List" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to akka-user+unsubscr...@googlegroups.com. > To post to this group, send email to akka-user@googlegroups.com. > Visit this group at https://groups.google.com/group/akka-user. > For more options, visit https://groups.google.com/d/optout. > -- >>>>>>>>>> Read the docs: http://akka.io/docs/ >>>>>>>>>> Check the FAQ: >>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user --- You received this message because you are subscribed to the Google Groups "Akka User List" group. To unsubscribe from this group and stop receiving emails from it, send an email to akka-user+unsubscr...@googlegroups.com. To post to this group, send email to akka-user@googlegroups.com. Visit this group at https://groups.google.com/group/akka-user. For more options, visit https://groups.google.com/d/optout.
