Okay, that makes sense. Thanks Konrad.
On Sun, May 7, 2017 at 10:27 PM, Konrad Malawski <
konrad.malaw...@lightbend.com> wrote:
> To clarify: You'll notice that it does actually work in the routing DSL,
> even if you supply a RawHeader it will attempt to extract the typed modeled
> header that you provide it with.
>
> This actually does work in the routing DSL:
>
> val routes = headerValueByType[*ApiTokenHeader*]() { token ⇒
> complete(s"extracted> $token")
> }
>
> Get().withHeaders(*RawHeader*("apiKey", "TheKey")) ~> routes ~>
> check {
> status should ===(StatusCodes.OK)
> responseAs[String] should ===("extracted> apiKey: TheKey") // so
> it matched the custom one
> }
>
> https://github.com/akka/akka-http/blob/master/akka-http-test
> s/src/test/scala/akka/http/scaladsl/server/ModeledCustomH
> eaderSpec.scala#L113:L120
>
> Seems we omitted to add the special logic that can do this to the
> HttpRequest / HttpResponse itself, since they are "low level",
> and usually did not do these things... I'll take a look if we could add
> that infrastructure there without breaking binary compatibility.
>
> --
> Konrad `ktoso` Malawski
> Akka <http://akka.io> @ Lightbend <http://lightbend.com>
>
> On 7 May 2017 at 20:56:22, Marco Yuen (mar...@gmail.com) wrote:
>
> Hi Konrad,
>
> I'm don't mean to hijack the thread, but I'm having the same question.
> Here is the custom header:
>
> final case class RateLimitLimit(limit: String) extends
> ModeledCustomHeader[RateLimitLimit] {
> override def companion: ModeledCustomHeaderCompanion[RateLimitLimit] =
> RateLimitLimit
>
> override def renderInRequests(): Boolean = true
>
> override def renderInResponses(): Boolean = true
>
> override def value(): String = limit
> }
>
> object RateLimitLimit extends ModeledCustomHeaderCompanion[RateLimitLimit] {
> override def name: String = "X-RateLimit-Limit"
>
> override def parse(value: String): Try[RateLimitLimit] =
> Success(RateLimitLimit(value))
> }
>
>
> When I tried to extract the header from HttpResponse using
> resp.header[RateLimitLimit], I always get None. However, if I use
> resp.header[RawHeader], I will get my custom header back, but only if
> there only one custom header in the response. If the response contains more
> than one custom headers, resp.header[RawHeader] will return first custom
> header.
>
> I'm using akka-http 10.0.6 and akka 2.5.1.
>
> Best,
> Marco
>
> On Monday, April 24, 2017 at 5:46:13 AM UTC-4, Konrad Malawski wrote:
>>
>> Hi Kyrylo,
>> Would you mind sharing your code for the transaction id header?
>>
>> That way of extracting a header does work, and I've added a test as we
>> were missing that specific style actually:
>> https://github.com/akka/akka-http/pull/1047
>>
>> I suspect you may have done something wrong in your header definition -
>> are you sure you defined everything that's needed?
>>
>>
>> See this test for more usage examples: https://github.com/a
>> kka/akka-http/blob/master/akka-http-tests/src/test/scala/akk
>> a/http/scaladsl/server/ModeledCustomHeaderSpec.scala
>>
>> On Fri, Apr 21, 2017 at 4:23 PM, Kyrylo Stokoz <k.st...@gmail.com> wrote:
>>
>>> Hi All,
>>>
>>> I`m trying to extract custom header from response object like this:
>>>
>>> response.header[`X-Transaction-Id`]
>>>
>>>
>>> but it always give me None, changing it to lookup by name return expected
>>> value.
>>>
>>>
>>> response.headers.find(_.lowercaseName() ==
>>> `X-Transaction-Id`.name.toLowerCase)
>>>
>>>
>>> It looks like it is related to modeling custom headers as RawHeader.
>>>
>>> According to
>>> http://doc.akka.io/docs/akka-http/10.0.5/scala/http/common/http-model.html:
>>>
>>> "Thanks to extending ModeledCustomHeader instead of the plain CustomHeader
>>> such header can be matched"
>>>
>>>
>>> Should it apply to header extraction in the way above as well? Is it a bug?
>>> or as designed?
>>>
>>>
>>> Regards,
>>>
>>> Kyrylo
>>>
>>> --
>>> >>>>>>>>>> Read the docs: http://akka.io/docs/
>>> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/c
>>> urrent/additional/faq.html
>>> >>>>>>>>>> Search the archives: https://groups.google.com/grou
>>> p/akka-user
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Akka User List" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to akka-user+...@googlegroups.com.
>>> To post to this group, send email to akka...@googlegroups.com.
>>> Visit this group at https://groups.google.com/group/akka-user.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Cheers,
>> Konrad 'ktoso' Malawski
>> Akka <http://akka.io/> @ Typesafe <http://typesafe.com/>
>>
> --
> >>>>>>>>>> Read the docs: http://akka.io/docs/
> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/c
> urrent/additional/faq.html
> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user
> ---
> You received this message because you are subscribed to the Google Groups
> "Akka User List" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to akka-user+unsubscr...@googlegroups.com.
> To post to this group, send email to akka-user@googlegroups.com.
> Visit this group at https://groups.google.com/group/akka-user.
> For more options, visit https://groups.google.com/d/optout.
>
> --
> >>>>>>>>>> Read the docs: http://akka.io/docs/
> >>>>>>>>>> Check the FAQ: http://doc.akka.io/docs/akka/c
> urrent/additional/faq.html
> >>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user
> ---
> You received this message because you are subscribed to the Google Groups
> "Akka User List" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to akka-user+unsubscr...@googlegroups.com.
> To post to this group, send email to akka-user@googlegroups.com.
> Visit this group at https://groups.google.com/group/akka-user.
> For more options, visit https://groups.google.com/d/optout.
>
--
*Greg Methvin*
*Tech Lead - Play Framework*
Lightbend, Inc. <https://www.lightbend.com/>
--
>>>>>>>>>> Read the docs: http://akka.io/docs/
>>>>>>>>>> Check the FAQ:
>>>>>>>>>> http://doc.akka.io/docs/akka/current/additional/faq.html
>>>>>>>>>> Search the archives: https://groups.google.com/group/akka-user
---
You received this message because you are subscribed to the Google Groups "Akka
User List" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at https://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.
