Re: [PATCH] few improvements ( repost )

[Sam Ruby]

Costin Manolache wrote:

However I think I'll still need a +1 on the patch I sent :-)
( it adds an optional attribute to the XML, and some customization
that may or may not have the best form )

Like Gump's curent implementation is the epitome of "best form". Not.

The only thing I would have done differently is

export CMD="..."
echo $CMD $OUT
echo $OUT
$CMD $OUT 2>&1

See <xsl:template match="cvs"> in bash.xsl for an example.

And then I *might* want to consider a "test $all &amp;&amp; " before the echo statements. That's only if the echo turns out to be too irritating when used interactively, but I'm not sure it would be. Have to try it for a while to see.

But if it makes you feel any better, +1.

- Sam Ruby


--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>