I'm hitting a bug running the testsuite for bash in Ch. 6. The problem
is that the stylesheet tries to add "-k" to make tests since I'm using
bomb-testsuite=n. It's ends up being applied to the previous block
too, and the build bombs because it tries to execute 'sed -i ... -k
tests/intl.tests.

Attached is a patch to fix this. It also means that the chown command
won't always return successfully with "|| true". Below is the
difference in the command outputs. I can apply this if you'd like.

diff -pNur lfs-commands.orig/chapter06/084-bash lfs-commands/chapter06/084-bash
--- lfs-commands.orig/chapter06/084-bash        2007-08-01
08:05:36.000000000 -0700
+++ lfs-commands/chapter06/084-bash     2007-08-01 08:20:39.000000000 -0700
@@ -10,8 +10,8 @@ patch -Np1 -i ../bash-3.2-fixes-5.patch
 ./configure --prefix=/usr --bindir=/bin \
     --without-bash-malloc --with-installed-readline
 make
-sed -i 's/LANG/LC_ALL/' -k tests/intl.tests
-chown -Rv nobody ./ >> $TEST_LOG 2>&1 || true
+sed -i 's/LANG/LC_ALL/' tests/intl.tests
+chown -Rv nobody ./
 su-tools nobody -s /bin/bash -c "make -k tests" >> $TEST_LOG 2>&1 || true
 make install
 exit
\ No newline at end of file

--
Dan
--- jhalfs-2.3/LFS/lfs.xsl.orig	2007-08-01 08:04:37.000000000 -0700
+++ jhalfs-2.3/LFS/lfs.xsl	2007-08-01 08:19:32.000000000 -0700
@@ -187,7 +187,7 @@
           <xsl:when test="$testsuite = '0' or $testsuite = '1'"/>
           <xsl:otherwise>
             <xsl:if test="not(contains(string(),'check')) and
-                          not(contains(string(),'tests'))">
+                          not(contains(string(),'make tests'))">
               <xsl:apply-templates/>
               <xsl:text>&#xA;</xsl:text>
             </xsl:if>
@@ -211,7 +211,7 @@
               </xsl:choose>
             </xsl:if>
             <!-- Bash -->
-            <xsl:if test="contains(string(),'tests')">
+            <xsl:if test="contains(string(),'make tests')">
               <xsl:choose>
                 <xsl:when test="$bomb-testsuite = 'n'">
                   <xsl:value-of select="substring-before(string(),'tests')"/>
-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to