Hi,

Currently, jhalfs copies the exact command for invoking GMP's tests:

make check 2>&1 | tee gmp-check-log >> $TEST_LOG 2>&1

The problem with this is that the exit status of 'make check' is lost;
the exit status of 'tee' is what will cause the script to fail or not,
and that's pretty much never going to fail to run.

The attached patch changes the command to:

make check 2>&1 | tee gmp-check-log >> $TEST_LOG 2>&1 && exit
$PIPESTATUS

I'm doing a full build now to test it, but it at least generates what I
think is the correct command line.

Regards,

Matt.
Index: LFS/lfs.xsl
===================================================================
--- LFS/lfs.xsl	(revision 3547)
+++ LFS/lfs.xsl	(working copy)
@@ -317,6 +317,10 @@
                        select="substring-before(string(),'2>&1')"/>
                     <xsl:text>&gt;&gt; $TEST_LOG 2&gt;&amp;1 || true&#xA;</xsl:text>
                   </xsl:when>
+                  <xsl:when test="contains(string(), 'tee gmp-check-log')">
+                    <xsl:apply-templates/>
+                    <xsl:text> &gt;&gt; $TEST_LOG 2&gt;&amp;1 &amp;&amp; exit $PIPESTATUS&#xA;</xsl:text>
+                  </xsl:when>
 		  <xsl:when test="contains(string(), 'make -k')">
 		    <xsl:apply-templates/>
 		    <xsl:text> &gt;&gt; $TEST_LOG 2&gt;&amp;1 || true&#xA;</xsl:text>
-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to