On May 11, 2014, at 4:54 PM, Pierre Labastie wrote:

Sorry, of course the else clause for fstab should also be
wrt_RunAsRoot "${file}" (I usually copy fstab, so this clause is not used for me)

Pierre

Ah yes, thanks for the patch. I was on the right path, just missing some things and was getting confused from testing different changes.
I've also added flags) for the flags page in our boot  ch7.

*flags) orphan_scripts="${orphan_scripts} $ {this_script}" ;;
and
 *flags)           wrt_RunAsRoot "${file}"    ;;

I'm testing as we speak.

I'm thinking since the earlier book only needed root for devices and changingowner, the new book needs those plus what we've added to be ran as root.

The most obvious is if config-system exists in clfs-commands.

The other major test is we can test something in boot/* (but probably not as desirable)

We can also test by using major-version in general.ent.

Since no other books in 1.x or 2.x major version series will ever use what we have in systemd branch (which is major-version 3 for our upcoming release), we could test for major version. If it is < 3 or > 2 then do something:

if > 2 (possibly even use >= 3 (meaning we are using the new layout, which could change in a next major veresion release like 4, or 5) then in the case statement use wrt_RunAsRoot

if < 3 (meaning we are using the older layout), then don't include them at all.

I would think the if >2 or if >=3 would be best if I am thinking properly about the logic.

I don't know if we would need to run the conditional and have multiple cases, or have the conditional within the case.

Sincerely,

William Harrington




--
http://lists.linuxfromscratch.org/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to