On 12/04/2019 22:54, Jeremy Huntwork wrote:
> Hello,
> 
> Pierre and I were talking about this in the lfs-dev list. I've started
> taking a look at the advice shellcheck (https://www.shellcheck.net/)
> would give for jhalfs and decided to submit a patch. There's more that
> could be done (I've started on some of the other pieces, too) but I
> figured I'd send in just the one for ./jhalfs itself first to see what
> you think.
> 
> Thanks!
> 
> JH
> 
> 

Thanks a lot. It's getting late here, so I have no time to fully review tonight.

Just one thing for now. I see you have used:

find <filename> -exec stat -c '%Y' {}

I'm not sure the syntax for find is correct, but anyway, since it is about
finding a single file, why not use directly:

stat -c '%Y' <filename>

?

I did not know stat, thanks for pointing it to me.

Pierre
-- 
http://lists.linuxfromscratch.org/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to