To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=24255
------- Additional comments from [EMAIL PROTECTED] Thu Jan 20 04:54:03 -0800 2005 ------- OD->ayaniger: I've got a first look at your patch. When loading the given document in SRC680m71 the considtion in the code you mentioned above as 1) isn't true. Thus, no adjustment is made to <pRecord>. So why does this code causes problems in importing this document? Do you checked, if the defects 15718 and 19008, for whose this code is introduced, are still fixed? The first part of the code you mentioned above as 2) - it has the comment: 111875 - is needed and already refined by the fix for issue 36649, because Microsoft Word horizontal position <left to page> respectively <right to page> doesn't correspond to the Writer horizontal position <left to page> and <right to page>. Thus, the horizontal position is converted. The second part of the code you mentioned above as 2) is for converting R2L horizontal positions - as I know. This code seems to be incomplete and doesn't fulfill completely the requirements. As I can see, this code is only performed for objects, which will be imported as Writer fly frames. It isn't performed for drawing objects -a s the object in the given document. This somehow this is what this issue is about. This code have to be adjusted I think. Your introduced code should be this adjustment. Am I right? I didn't have got a deep look at your changes to the file <anchoredobjectposition.cxx>. But, I tested the horizontal position <center to character> and <right to character> in a R2L Writer document and everything is fine. Thus, why do you want to adjust this code? This code is about the positioning of anchored objects. If this code isn't correct or works as excepted, it would do for all documents (not even Microsoft Word documents). I can't see that this code doesn't work as excepted. Summary: In the current situation I can't give my approval to the code change of file <anchoredobjectposition.cxx>. The removing of the code snips from method <SwWW8ImplReader::ProcessEscherAlign(..)> isn't clear to me. Your new code in this method needs further investigations - I think, as mentioned above, it seems to be a correct step to the conversion of horizontal positions in R2L Microsoft Word documents, which are still calculated L2R, to R2L Writer positions. Please give your comments. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
