To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=57755


User fs changed the following:

                  What    |Old value                 |New value
================================================================================
               Assigned to|fs                        |af
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Wed Nov 23 05:21:09 -0800 
2005 -------
fs->ab: One problem here is that Impl_GetSupportedInterfaces does not catch
RuntimeExceptions (or any others) thrown during calling getTypes (or any other
UNO method). This is why it finally crashs. I suggest adding more robustness to
this code, else every UNO component has the potential to crash the whole
application.

fs->cl: The reason why the exception is actually thrown in queryInterface is
because SdDrawPage::getTypes allocates a css.uno.Type sequence which is larger
than actually needed. Thus, a "void" type is part of this sequence, and returned
as supported type. The Basic runtime then queries for this "void" type ...
Adjusting |nOwnTypes| in |SdDrawPage::getTypes| easily fixes the problem, I
think the reason is the fragile construct used in this method:
  sal_Int32 nOwnTypes = 10;      // !DANGER! Keep this updated!
Well, the DANGER hits here - 9 is what's really needed. May I suggest using
things like a vector::push_back and comphelper::concatSequences to make the code
less error-prone?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to