To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Wed Nov 30 03:25:31 -0800 2005 ------- In message "[Issue 53572] MinGW port efforts and information for SRC680 codeline", [EMAIL PROTECTED] wrote... >@tono: binfilter/inc/bf_sw/doc.hxx there are string 1627 commented (with //) and >I see no reason why it should be uncommented. I do not have anything against >bugfixing, but in this case they complexify the code review and cannot be >accepted for "pure" port changes. > The reason why I made patches for binfilter/inc/bf_sw/doc.hxx and binfilter/bf_sw/source/core/doc/sw_doc.cxx to revive the function "const SwFmtRefMark* SwDoc::GetRefMark( sal_uInt16 nIndex ) const" and prevent the build break in binfilter/bf_sw/source/core/unocore/sw_unocoll.cxx. Please note that sal_Unicode is compatible with sal_uInt16 on all platforms but not on mingw by "#define sal_Unicode wchar_t". "#define sal_Unicode unsigned short" is another option but I chose not to do so after the discussion in i#29615. The countermeasures that I think of are the following two: 1) Use #ifdef block and revive the function only for mingw. It would not be a good solution as the program logic becomes different. 2) Use cast to tentatively avoid build break in binfilter/bf_sw/source/core/unocore/sw_unocoll.cxx const SwFmtRefMark* pMark = GetDoc()->GetRefMark( (sal_Unicode)(sal_uInt16) nIndex ); and report another issue claiming possible bug here. Are there any better measure? tono (Takashi Ono) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
