To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59041
                  Issue #:|59041
                  Summary:|64bit: long vs. sal_Int32 in
                          |fpicker/source/office/iodlg.cxx
                Component:|gsl
                  Version:|OOo 2.0
                 Platform:|All
                      URL:|
               OS/Version:|All
                   Status:|NEW
        Status whiteboard:|
                 Keywords:|
               Resolution:|
               Issue type:|PATCH
                 Priority:|P3
             Subcomponent:|code
              Assigned to:|pl
              Reported by:|pjanik





------- Additional comments from [EMAIL PROTECTED] Wed Dec  7 10:15:57 -0800 
2005 -------
Hi,

for 64bit machines, we need this:

diff -ur ooo_SRC680_m140_src.orig/fpicker/source/office/iodlg.cxx
ooo_SRC680_m140_src/fpicker/source/office/iodlg.cxx
--- ooo_SRC680_m140_src.orig/fpicker/source/office/iodlg.cxx    2005-11-17
12:24:18.000000000 +0100
+++ ooo_SRC680_m140_src/fpicker/source/office/iodlg.cxx 2005-11-17
12:24:47.000000000 +0100
@@ -2771,7 +2771,7 @@
                // Dieses Resize wurde nur zum Ein - oder Ausblenden des 
Indicators aufgerufen
                return;
 
-       long nMaxYPos = 0;
+       sal_Int32 nMaxYPos = 0;
 
        // -------------
        // move controls

because it is used only as the last argument for lcl_MoveControl

void lcl_MoveControl( Control* _pControl, sal_Int32 _nDeltaX, sal_Int32
_nDeltaY, sal_Int32* _pMaxY = NULL )

and not used for anything else.

Now when I'm looking at it, what about removing it completely and shorten the
calls to lcl_MoveControl because the last argument defaults to NULL anyway?

Do you have a cws for this for 2.0.2 or should we include it in some 64bit cws?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to