To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59838


User cl changed the following:

                  What    |Old value                 |New value
================================================================================
               Assigned to|wg                        |cl
--------------------------------------------------------------------------------
            Ever confirmed|                          |1
--------------------------------------------------------------------------------
                    Status|UNCONFIRMED               |NEW
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Thu Dec 29 01:53:17 -0800 
2005 -------
fixed in cws impress81,

found the real problem, this is clearly a regression to cws impressfunctions.

In DrawViewShell::FuPermanent() there once was this code

        pFuActual = new FuText(this, GetActiveWindow(), pDrView, GetDoc(), 
rReq);
        ( (FuText*) pFuActual)->DoExecute();

that was replaced in impressfunctions with

        SetCurrentFunction( FuText::Create(this, GetActiveWindow(), pDrView, 
GetDoc(),
rReq) );

This was done because I moved all implementations from the c'tor to the general
FoPoor::DoExecute() derivations. FuText was the only FuPoor derivate that
already used that schema. And in the new version the current function was not
set at the draw view shell while FuText::DoExecute was called. This caused
DrawViewShell::SelectionHasChanged() to behave different in this code statement

        if( HasCurrentFunction() )
        {
                GetCurrentFunction()->SelectionHasChanged();
        }
        else
        {
        GetObjectBarManager().SelectionHasChanged (pDrView);
        }

So instead of calling FuText::SelectionHasChanged(),
GetObjectBarManager().SelectionHasChanged() was called which caused the
activation of the drawing object toolbar.

I fixed this be moving the DoExecute call from FuText::Create() to
DrawViewShell::FuPermanent()

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to