To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59407


User mhu changed the following:

                  What    |Old value                 |New value
================================================================================
               Assigned to|hro                       |kendy
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Mon Jan 16 02:42:55 -0800 
2006 -------
Hi Jan, Pavel,

I've now (quickly) reviewed the attached patch, but also don't know of a test to
verify it. Someone would need to lookup places where the using classes (e.g.
sd's PropItem) are itself used, and than see whether a test exists.

OTOH, as the patch only factors out duplicate code from 'sfx2' and 'sd'
(afaics), and moves it into class DateTime, I don't really see a problem with
this patch => approved.

As usual, please integrate into a cws of your choice.

If there are still doubts whether this datetime crunching is correct at all,
please ask Eike ([EMAIL PROTECTED]) for an additional review.

HTH,
Matthias


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to