To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35483
------- Additional comments from [EMAIL PROTECTED] Mon Jan 16 09:42:59 -0800
2006 -------
Hi Muthu,
You're nearing it ;-) Note that it isn't necessary to implement the
same logic twice for svSingleRef and svDoubleRef, as we have a helper
method PopDoubleRefOrSingleRef() for use in higher level functions. And
while at it, we could already differentiate between string and numeric
values, instead of converting numeric values to string and back. The
resulting path would be something like (untested)
switch (GetStackType())
{
case svDouble:
PushDouble( PopDouble());
return;
break;
case svSingleRef:
case svDoubleRef:
{
ScAddress aAdr;
if (!PopDoubleRefOrSingleRef( aAdr))
return;
ScBaseCell* pCell = GetCell( aAdr);
if (!pCell)
{
PushDouble(0.0);
return;
}
else if (pCell->HasValueData())
{
PushDouble( GetCellValue( aAdr, pCell));
return;
}
GetCellString( aInputString, pCell);
}
break;
default:
aInputString = GetString();
}
Btw, when creating String objects it isn't necessary to assign them
EMPTY_STRING, the default ctor already initializes them as empty.
EMPTY_STRING is a static String object and is used when you want to
avoid the creation of a temporary String object. Btw2, StackVar
stackType is an unused variable.
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
