To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Thu Jan 19 07:53:10 -0800 2006 ------- @tono: <quote>I can go back to a)+ b) but there are so many windows specific modules mixed sal_Unicode and wchar_t and the patch set becomes huge.</quote> IMO that would be the cleanes solution, however---treat sal_Unicode as an abstract type that might or might not conicide with wchar_t or any other type. That way, the OOo code base would be most flexible, which could be helpful for future ports. That of course means that all the (Windows-only) code that makes liberal use of the fact that currently sal_Unicode==wchar_t==unsigned short has to be looked at and fixed (reinterpret_cast between OOo's sal_Unicode and OS's wchar_t; rtl_ustr... instead of wcs... where appropriate, static sal_Unicode[] instead of L"..." where appropriate, etc.). I added hro to cc, who might have an opinion on this, too (at least for the sal/osl part). <quote>And follow-up is required for almost all windows modules being added in the future.</quote> Not if you educate developers to be aware of these issues. ;) <quote>BTW do you think it ok not to enclose "reinterpret_cast"s in #ifdef __MINGW32__?</quote> IMO that is ok; for wntmsci10, that reinterpret_cast would simply be a noop then. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
