To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=61174





------- Additional comments from [EMAIL PROTECTED] Sun Jan 29 12:10:56 -0800 
2006 -------
ericb->mox

Your patch does not apply on m154, because some kde stuff has been removed.

I have written a patch that you can apply with m154.  vcl builds fine with it 
on m153, but I don't know if 
I'm wrong or not.

The problem I have is :

when instantiate MACOSXIntegrator()  ?  In your code, it was made twice, and I 
have not understood 
why. From my side, instead of use (KDEIntegrator is missing in m154) :

""""""""""""""""""""""""""""""""""
 @@ -118,6 +121,8 @@
 #endif
         if( aOver.equalsIgnoreAsciiCase( "kde" ) )
             return new KDEIntegrator();
+        if( aOver.equalsIgnoreAsciiCase( "macosx" ))
 # nclude <sareturn new MACOSXIntegrator();
         if( aOver.equalsIgnoreAsciiCase( "none" ) )
   )         return new DtIntegrator();
     }
@@ -138,6 +143,9 @@
+    if( pSalDisplay->getWMAdaptor()->getWindowManagerName().EqualsAscii( "Syste
mUIServer.app" ) )
+               return new MACOSXIntegrator();
+
        // default: generic implementation
        return new DtIntegrator();
 }
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

I just create MACOSXIntegrator if WindowManagerName().EqualsAscii is 
SystemUIServer.app  :

"""""""""""""""""""""""""""""""""""""""""""""""""""""""""
@@ -142,8 +145,12 @@
        }
 #endif
  
+    if( pSalDisplay->getWMAdaptor()->getWindowManagerName().EqualsAscii( 
"SystemUIServer.app" ) )
+               return new MACOSXIntegrator();
+    else
"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

I have not tested. Of course, if I'm wrong, please let me know





---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to