To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Tue Feb 21 01:13:17 -0800 2006 ------- Tono, great work. Just browsing through some of the files from your latest patch (OOB_680m1_mingw_patch.zip) I have a few questions/comments: 1 For example in bridges_mingw.patch, there are patches against files in bridges/source/cpp_uno/mingw_intel/, a directory that does not exist on OOB680m1. So I wonder whether that patch.zip is self-contained or relies on some earlier patches? 2 "I decided to enclose unicode string fix here and there within #ifdef __MINGW32__ - #endif." My understanding is that the __MINGW32__ code version should work for all platforms, but you are reluctant to break anything for platforms other than mingw and thus leave the code in its original form for all other platforms, right? I personally believe that the added #ifdefs make the code less readable/maintainable, and so you should just be bold and change the code for all platforms; but maybe the code owners of the relevant areas have an opinion, too (I found occurrences of this in the win32 parts of sal_mingw.patch, but also, for example, in the only patch in accessibility_mingw.patch). --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
