To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=46895
------- Additional comments from [EMAIL PROTECTED] Fri Feb 24 01:18:07 -0800
2006 -------
I don't think Jayant is looking after this anymore, anyway there was a bug with
the original patch ( it seems attaching an unsaved ( untitlted ) document as pdf
just doesn't work ) ).
So, yes agreed the excessive Slot usage is a problem. I have reworked the patch
to cater for that as per your sugguestions. But, unfamiliarity with SIDs,
resource files and such leave me with more questions. So first a little about
the patch, then I'll try and outline my questions.
a) removed SID_MAIL_SENDDOCASPDF, so "Send Mail", "Send Mail as PDF attachment",
"Send Mail as MS xxxx attachment" all now use the same command. :-)
b) I didn't change the name of either the existing SLOT or the existing command,
of course if thats really an issue thats not a problem to change ( imo the
existing command with the additional filter arg is clear enough ) e.g. for calc
the commands are as follows
+ ".uno:SendMail" for attach 'this' calc doc
+ ".uno:SendMail?FilterName:string=calc_pdf_Export" attach doc as pdf
+ ".uno:SendMail?FilterName:string=MS Excel 95" attach doc as XL file
c) a good thing is now the SfxMailModel_Impl::SaveDocAsPDF method is no more,
and a fair amound of code duplication gone with it, see the patch for more info.
so to my questions,
a) in the patch I removed a number of instances of
SID_MAIL_SENDDOCASPDF/ITEM_FILE_MAIL_SENDDOCASPDF, in svx/inc/globlmn_tmpl.hrc
these seem to defined the help-id and translations for en & de. I thought that
the translations were defined in the xml file. Maybe this is an artifact from a
previous implementation, could you clarify
b) Similarly in sd/source/ui/app/menuids2_tmpl.src it seems there is a
redundandt Menu structure definition, again info on that would be great
I'd dearly like to get this into OO2.0, maybe its possible for 2.0.3, I'm
willing to help out to do that.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
