To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=64301





------- Additional comments from [EMAIL PROTECTED] Thu Apr 27 06:19:54 -0700 
2006 -------
OD->jianhuajiao:
I think the second patch, which you have commited, is the one, that should fix
the layout. Right?

Can you please state, what the intention of the changed/new code is?

First comment to your following new code:
1        const SwFrm* pFrm = FindFooterOrHeader();
2        if ( IsHeaderFrm() || IsFooterFrm() )
3        {
4            if ( pFrm->GetDrawObjs() )
5                pPage->InvalidateCntnt();
6            if ( this == pFrm )
7            {
8                       pRoot->SetIdleFlags();
9                return;
10            }
11       }

Local variable <pFrm> will be a header frame or a footer frame - see code line
1. header/footer frames doesn't have any anchored objects assigned. Anchored
objects assigned to frames are stored in the data structure retrieved by method
<SwFrm::GetDrawObjs()>. Thus, condition in code line 4 will always be <false>.
Thus, code line 5 will never be executed. Thus, code lines 4 and 5 can be
deleted. When these code lines are deleted, the code can be simplified to:
2        if ( IsHeaderFrm() || IsFooterFrm() )
3        {
8                       pRoot->SetIdleFlags();
9                return;
11       }

Information of anchored objects:
Anchored objects are Writer fly frames (text frame, graphics and OLE objects)
and drawing objects, which can be assigned to paragraphs for anchor types "to
paragraph", "to character" and "as character", to text frames for anchor type
"to frame" and to pages for anchor type "to page". Paragraphs are represented in
the layout by instances of class <SwTxtFrm>, text frame by instances of class
<SwFlyFrm> and pages by instances of class <SwPageFrm>. All these classes are
derived from base class <SwFrm>.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to