To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=54275





------- Additional comments from [EMAIL PROTECTED] Thu Apr 27 10:30:22 -0700 
2006 -------
No, an #ifdef UNX would be even more worse. ;-)

The configuration should be used to control features.

Yes there's other usage of environment variables but this should only be the
case if this is the only way for something that's used during bootstrapping or
similar and just controls a technical feature.
F.e. using Open GL, X fonts etc. or not does not really modify the feature set
of OOo but disabling Auto Recovery does. And SAL_ENABLE_FILELOCKING is a
workaround for some locking problems that are file system issues that can't be
controlled by OOo. Furthermore it's not possible to use the configuration API in
SAL.

The right way to introduce an environment variable would be by using "#if
OSL_DEBUG_LEVEL > 1" because the solution is for debugging purposes. The
Control-C stuff is not Unix only, take a deeper look into
sal/systools/guistdio/guistdio.cpp which I wrote for Windows. It enables Windows
GUI programs to printf to a console, being terminated by Control-C etc., so
believe me I know what you mean. ;-)

But - my biggest concern is something different. I want those environment
variables to be documented. There are many many other guys that write issues
"give me that env var for disabling/enabling this feature or that feature". Main
brain is to small to remember all those stuff if I would accept those patches.

But I would prefer to continue a discussion offline, not inside an issue.








---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to