To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=63376





------- Additional comments from [EMAIL PROTECTED] Tue May  2 05:53:27 -0700 
2006 -------
obr: your patch looks nice and simple :) however, even though the OOo compiles
and runs with that patch, I'm not fully confident that the native cups is fully
used. 

Looking at the code in OOo, there seems to be many places, where #ifdef MACOSX
-defines explicitly direct Mac OS X to use different code than other unixes. So,
I think there needs to be several places, where #ifdef MACOSX is changed to #if
defined(MACOSX) && !defined(ENABLE_CUPS). (look at my original patch) 

For other things, I agree that it is not necessary to change the old
(Mac-specific) code. 

As for config_office -stuff, I think the only necessary thing is to make sure
darwin*) -sections have enable_cups=yes (both configure and configure.in). The
current code already checks for cups/cups.h and issues warning if it is not
found. I think that is enough. Mac OS X build instructions on the web can then
specifically inform that building on Panther and --enable-cups, requires
manually adding the headers.

I wish I had more time to work on this stuff, but unfortunately not.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to