To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66693 Issue #|66693 Summary|sax: wrong usage of the function AddBytes Component|xml Version|OOo 2.0.2 Platform|PC URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|pmladek
------- Additional comments from [EMAIL PROTECTED] Fri Jun 23 07:59:20 -0700 2006 ------- I investigated the sax code. As a side effect, I found some locations where the function AddBytes is not used correctly in sax/source/expatwrap/saxwriter.cxx. I'll attach a patch: - The first hunk fixes a typo. It is obvious that the author wanted to add four bytes. - The second hunk probably is not necessary. I added it just for sure. - The third hunk fixes a missusage of AddBytes. The problem appeared if (nCurrentPos + nLen + 1 == SEQUENCESIZE). Then AddBytes called writeSequence when the buffer was not full. The one character LINEFEED was added too late. By other words, AddBytes must be called only when (rPos + nBytesCount >= SEQUENCESIZE) and this was not the case because it might happen that (nCurrentPos + nLen == SEQUENCESIZE - 1) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
