To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=66729


User fs changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'cmc,fs,sb'               |'cmc,fs,kendy,sb'
--------------------------------------------------------------------------------
             Assigned to|kendy                     |fs
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Sun Jun 25 23:59:46 -0700 
2006 -------
> The function
> BOOL ODbaseTable::ReadMemo(ULONG nBlockNo, ORowSetValue& aVariable)
> is completely new in warnings01

No, it previously was in DNoException.cxx. This file collected methods to be
compiled without exception support. Which, with warnings01, showed to be a
mistake: Including STL headers and using STL functionality already requires
exception support nowadays. So I moved all the content from DNoException.cxx to
the files implementing the rest of the respective classes.

> Shouldn't nLength be sal_uInt32 instead of ULONG (it compiles when
> changed).

Interestingly, in the old version, in DNoException.cxx, nLength *was* a
sal_uInt32. The fact that it now is a ULONG makes me hop^Wthink I did this for a
reason, though I don't remember which. Will investigate.

> I was bit surprised to find completely new function in the cws that
> should fix warnings only

(Fixing reasons instead of symptoms sometimes requires this - though it wasn't
the case here. And I definately did not want to make the code warning-free by
doing cosmetic changes which just pretend everything's right ...)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to