To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62422
------- Additional comments from [EMAIL PROTECTED] Mon Jul 24 03:22:21 -0700 2006 ------- On Wed, 2006-07-19 at 14:39 +0200, Svante Schubert wrote: > Hi Caolán, > > Some things I would like to discuss with you concerning our > XALANUPGRADE CWS: > 1. Is it possible to provide us some links to the install sets > for testing? ;-) http://ooo.services.openoffice.org/pub/OpenOffice.org/cws/upload/xalanupgrade/ > 1. Is it possible to do an 'cwsview' on the CWS to find out the > changes? attached is the full workspace patch (ignoring the changed jar binaries), it's quite small > > The main change to the earlier used Xalan 2.6 implementation > is that a new serializer.jar has been splitted from the Xalan > jar > My test approach would be: > find . -type f | xargs egrep -i "xalan.jar" > > With this I found in a m174 the following files: > > ./filter/source/config/fragments/makefile.mk: > ./filter/source/xsltfilter/Manifest: > ./filter/source/xsltfilter/makefile.mk: > ./filter/source/xsltvalidate/makefile.mk: > ./scp2/source/ooo/makefile.mk: > ./scp2/source/ooo/profileitem_ooo.scp: > ./xmerge/java/build.xml: > ./xmerge/java/org/openoffice/xmerge/converter/xml/xslt/build.xml: Note the xalan jars which are users of seralizer.jar mention seralizer.jar in their Class-Path in the upsteam jars which this workspace adds, so it definitely needs to be added to scp2, but doesn't need to be added to every CLASSPATH in the source tree because if the user jar has the Class-Path entry mentioning the serializer.jar then it gets found that way. > 1. I realized, that the choice of the preselection of the added > Xalan processor by Java property - I meant to have it earlier > added long ago - , is no longer available in the sources. > (find . -type f | xargs egrep -i > "javax.xml.transform.TransformerFactory", did not result > something useful). Therefore I recommend to add a new > enhancement to this CWS as well as it has exact the same test > effort/approach. > Concerning the implementation, I suggest to use a generic > preseclection by Java property in > "filter/source/xsltfilter/XSLTransformer.java" with > 'javax.xml.transform.TransformerFactory=org.apache.xalan.processor.TransformerFactoryImpl' as default. Now, I'm afraid that with fedora's move to gcc 4, it's not possible anymore for me to create any workspaces which are able to pass automated Hamburg QA, so I can't actually build any QA-suitable workspaces. So I suggest you take ownership of the workspace, as you can create modern workspaces which are qa-able. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
