To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68073
                 Issue #|68073
                 Summary|Check for NULL in svx/source/dialog/splwrap.cxx
               Component|Drawing
                 Version|680m179
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|ka
             Reported by|kendy





------- Additional comments from [EMAIL PROTECTED] Wed Aug  2 04:19:05 -0700 
2006 -------
This is a follow-up for issue 32320; there has been a patch that makes 
WAIT_ON()/WAIT_OFF() check pWin for NULL before actually using it.

We still have this patch in ooo-build; and though it does not fix any actual 
crash now according to the state of the original issue, I guess there's nothing 
wrong with integrating it anyway ;-) - could you please have a look?

The patch:

--- svx/source/dialog/splwrap.cxx
+++ svx/source/dialog/splwrap.cxx
@@ -125,8 +125,12 @@
 
 #include "dialogs.hrc"
 
-#define WAIT_ON()      pWin->EnterWait()
-#define WAIT_OFF()     pWin->LeaveWait()
+//#define WAIT_ON()    pWin->EnterWait()
+//#define WAIT_OFF()   pWin->LeaveWait()
+
+#define WAIT_ON() if(pWin != NULL) { pWin->EnterWait(); }
+
+#define WAIT_OFF() if(pWin != NULL) { pWin->LeaveWait(); }
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to