To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664
------- Additional comments from [EMAIL PROTECTED] Wed Aug 23 03:53:31 -0700 2006 ------- fs->jianhuajiao: thanks for the update. Unfortunately, there's something left: > if ( ::rtl::OUString( (sal_Unicode*)_rDest.getStr() ).getLength() != > _rSource.getLength() ) That, sorry, is nonsense. It creates an Unicode string from a byte array which in real represents an encoded 8-bit-string, which will give every possible result, but certainly not the one desired. In particular, this will access unowned memory (and thus potentially crash) if the byte string is not terminated with 2 zeros, but only one, since in this case there is no terminating sal_Unicode in the array. Please replace this with a simple check of "_rDest.getLength() != ...". And please do not attach patches which make me think you only compiled, but never actually tried them. Thanks ;) Also, I asked you to remove adjustCharSets completely - at the moment, it's a dead corpse not doing anything useful, so we should get rid of it. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
