To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68903 Issue #|68903 Summary|Make lingucomponent warning-free on wntmsci10 Component|lingucomponent Version|680m182 Platform|PC URL| OS/Version|Windows, all Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|other Assigned to|[EMAIL PROTECTED] Reported by|sb
------- Additional comments from [EMAIL PROTECTED] Wed Aug 23 09:21:28 -0700 2006 ------- It was originally planned to make module lingucomponent warning-free on CWS sb59. However, halfway into that endeavor I had to back out again, as way too many changes are necessary. Most wntmsci10-specific (i.e., MSC-specific) warning occurences are for "warning C4244: conversion from 'type1' to 'type2', possible loss of data" and "warning C4706: assignment within conditional expression." At least part of the code is in bad shape: - Mixing short and int for no apparent reason (e.g., short numsyllable vs. int oldnumsyllable in lingucomponent/source/spellcheck/hunspell/affixmgr.cxx:1.5). - Fourty-line-long conditional expressions in if statements, containing deeply nested assignments (e.g., rv = affix_check(st,i) within lingucomponent/source/spellcheck/hunspell/affixmgr.cxx:1.5 l. 1558--1597). - Weird indentation making nesting visually non-obvious (again seen for example in lingucomponent/source/spellcheck/hunspell/affixmgr.cxx, this might be caused by 4-vs.-8 tabstop issues, but that could have been fixed on initial import into OOo, adapting to OOo's conventions of 4-indentation, 4-tabstops, and avoiding hard tabs where possible; also, legal headers are missing from files...). For the platforms unxlngi6, unxsoli4, and unxsols4, lingucomponent has already been made warning-free, but that only required small changes. The person to do this task for wntmsci10 should ideally know the code well and know how to effectively regression-test any changes made. Once lingucomponent is warning-free for wntmsci10, remove "lingucomponent" from the MODULES_WITH_WARNINGS list in solenv/inc/wntmsci10.mk (and if that leaves the list empty, see the accompanying comment for what to do in that case). As I said, I already made some changes on CWS sb59 and then backed them out again. For reference, the changes made were source/hyphenator/altlinuxhyph/libhnj/hyphen.c 1.6 -> 1.6.8.1 source/spellcheck/hunspell/affentry.cxx 1.3 -> 1.3.18.1 source/spellcheck/hunspell/affentry.hxx 1.3 -> 1.3.18.1 source/spellcheck/hunspell/affixmgr.cxx 1.5 -> 1.5.4.1 source/spellcheck/hunspell/affixmgr.hxx 1.4 -> 1.4.8.1 source/spellcheck/hunspell/atypes.hxx 1.3 -> 1.3.18.1 source/spellcheck/hunspell/suggestmgr.cxx 1.4 -> 1.4.8.1 --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
