To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929
User sb changed the following: What |Old value |New value ================================================================================ CC|'joergwartenberg' |'joergwartenberg,sb' -------------------------------------------------------------------------------- ------- Additional comments from [EMAIL PROTECTED] Mon Aug 28 00:34:11 -0700 2006 ------- The proposed patch makes the code unnecessarily complex, by lumping together definition and use of the various strings as PROPNAME_ macros using PROPNAME_IMPL_DECL macro to differentiate the two cases. Why not have as interface an enum of propname values together with an (inline) accessor function rtl::OUString getPropname(enum Propname), getting rid of all the macro stuff. Also, initialization should not use broken double checked locking pattern, but instead the rtl/instance.hxx stuff (and no fprintf logging). --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]