To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=26865





------- Additional comments from [EMAIL PROTECTED] Tue Aug 29 02:08:26 -0700 
2006 -------
Hi Rene, some comments:
- I would avoid defining LARGEFILE_SOURCE, as it seems to be the case in your
patch anyway.
- Should one use "getconf" for getting the linker and compiler flags (e.g. as
recommended in http://www.suse.de/~aj/linux_lfs.html)?
- What is that "LARGE_FILES" define for?
- IMHO, the 'IF "$(LFS_CFLAGS)" != ""' protecting the extension of the flags is
unnecessary
- Last but not least, we should turn this on by default for all OOo builds etc.

Otherwise it looks good :-)



---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to