To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=69051


User pl changed the following:

                What    |Old value                 |New value
================================================================================
        Target milestone|---                       |OOo 2.1
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Thu Sep  7 09:51:57 -0700 
2006 -------
I don't see how m_aPrevKeyPresses can be empty in the commit callback: you
should only be able to come here via gtk_im_context_filter_keypress, that is
while still being in handleKeyEvent. The only way this could happen is that an
IM "eats" an event but actually returns "false" in
gtk_im_context_filter_keypress, this would lead to handleKeyEvent popping an
event from the stack falsely. The m_aPrevKeyPresses.empty() in signalCommit is
actually just a sanity check to avoid accessing an empty list in weird 
conditions.

BTW: the single key handling is just a workaround itself; many controls do not
handle extended text input and therefore rely on corresponding key events -
including by the way on the modifier state which cannot be determined without a
key event. I guess that normally these would not get filtered, but i would not
necessarily want to rely on that thinking of the many many input methods we're
talking here.

However this leaves us with a key event (cursor right in this case), which gets
a "replaced" unicode by the IM, certainly a valid case, which is not handled
well currently. As immediate measure i think we could change
CheckSingleKeyCommitHack so it would return false for gdk keyvals that do not
correspond to a unicode (like cursor keys, function keys, etc.)

What's your opinion ?

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to