To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=53572
------- Additional comments from [EMAIL PROTECTED] Sat Sep 23 23:02:26 -0700 2006 ------- @vg: 1) ause's comments for solenv changes All his comments are valid and I am fixing them along with the changes for cygwin compiler 2) dtrans/util/makefile.mk Needs fix. 3) sb's comments for sal I will try to improve them so as to remove unnecessary complexity. 4) setup_native/source/win32/customactions/reg4msdoc/registryw9x.cxx #if defined(_MSC_VER) && (_MSC_VER < 1300) will be replaced by #if !defined(__MINGW32__) && (_MSC_VER < 1300) 5) setup_native/source/win32/customactions/reg4msdoc/registrar.cxx I have removed SHELL_COMMAND because it is not a namespace nor a class name. Enum name is not alllowed for name qualification in gcc nor in standard C++, I think. 6) config_office/configure.in I will make patch for it. 7) python/makefile.mk PWDCMD seems to be obsolete and will be removed. Incremental ADDITIONAL_FILES are only required for mingw but will not do any harm to other platforms and I think it better to set them for all platforms to keep one patch file for all platforms. 8) libxmlsec/makefile.mk Incremental ADDITIONAL_FILES are set for all platforms because of the same reason as above. LIBXML2LIB=$(LIBXML2LIB) ZLIB3RDLIB=$(ZLIB3RDLIB) are set because of the changes in libxml2-config. 9) stl_gcc.h I will review it but more concrete comment would be appreciated. tono (Takashi Ono) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
