To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=66693
------- Additional comments from [EMAIL PROTECTED] Tue Oct 17 11:57:40 -0700 2006 ------- The first change is important, see issue 70495. Invalid files are written (this is why I came across this). For the second change I agree with mib: That check is always done *after* incrementing nCurrentPos. Adding the check there would only make these semantics unclear to someone reading the code. For the third change, the problem with the old code is of course with nCurrentPos+nLen==SEQUENCESIZE, when the text without linefeed would fit into the buffer, but AddBytes is called for it. I'm not sure if this can really happen, or if startDocument is only ever called with an empty buffer. Even then, it looks like it would only cause an assertion message. It should probably be changed anyway. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
