To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=71264
User cd changed the following: What |Old value |New value ================================================================================ CC|'' |'sb' -------------------------------------------------------------------------------- ------- Additional comments from [EMAIL PROTECTED] Wed Nov 8 01:55:19 -0800 2006 ------- cd->bero: Hi bero, thanks for your patch. We have some concerns about your changes as you use hard casts. As you can read in our warning free code effort, we discourage from using hard cast (http://wiki.services.openoffice.org/wiki/Writing_warning-free_code). You should at least use the proposed sal::static_int_cast<sal_Bool> to solve the gcc 4.2 problems. I discussed it with sb (who currently maintains the warning free code effort) and we agreed that the best solution would be to change the declarations of the boolean members. Our propose solution would be to use bool instead of sal_Bool abc : 1. UNO already supports bool so there shouldn't be any problem. What do you think? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]