To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68047
------- Additional comments from [EMAIL PROTECTED] Thu Nov 9 11:29:54 -0800 2006 ------- Hi, I have my reservations regarding cmc's patch that was applied to fix this bug. It should fix the ZWJ issue I was seeing with Open Office and Sinhala since early 2006 (http://mail.lug.lk/lurker/message/20060410.130454.19cefb01.en.html). However, 1) The reporter of issue 51400 was testing on Linux systems which should have been using ICU as the renderer. It was indicated there was "No problem with win32". Therefore, the bug should have been opened for ICU, not openoffice. Hence, perhaps there's an argument for completely yanking that patch. 2) Maybe there's a better way to approach the IsControlChar() function. At the moment for a common character, like a letter from the English alphabet, there are six (6) 'if statements' that have to be completed before returning false. And for 'control' characters, in the worst case, there are 6 'if statements before returning true. Would it not be better to add a first 'if statement' to check whether the char is within the common range U+0020 (space) to, let us say, U+2027 (hyphenation point) and return false immediately? The fast path will ensure that for the majority of characters analysed by IsControlChar() it will return after one 'if statement' and for a minority of chracters it will, in the worst case, return after 7 'if statements'. 3) The patch also stops filtering out U+200B (ZERO WIDTH SPACE) but continues to filter out U+200E (LEFT-TO-RIGHT MARK) and U+200F (RIGHT-TO-LEFT MARK). I suspect LRM and RLM are required more than ZWS, if the renderer is allowed to do the BiDi analysis. I have discussed this filtering issue with Eric Mader (ICU) and Behdad Esfahbod (Pango). We all feel that an application, e.g. openoffice, should not be filtering formating characters that are required by the renderer for the correct layout of text. BTW, Eric also mentioned that ICU has a ParagraphLayout class in the Layout Extensions Library which does the BiDi analysis. Regards, Harshula --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
