To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=72366 Issue #|72366 Summary|Cleanup - remove dead code: Mac OS System 9 and earlie |r Component|porting Version|OOo 2.1 Platform|Macintosh URL| OS/Version|Mac OS X Status|UNCONFIRMED Status whiteboard| Keywords| Resolution| Issue type|TASK Priority|P3 Subcomponent|MacOSX Assigned to|mox Reported by|mox
------- Additional comments from [EMAIL PROTECTED] Thu Dec 7 08:08:57 -0800 2006 ------- In OpenOffice.org codebase, there is still lot of dead code related to the ancient Mac OS System 9 port. Basically any code that is only related to 1) "$(GUI)" == "MAC", 2) "$(OS)" == "MAC" or 3) #ifdef MAC can be safely removed. The Mac OS X port does not use these settings. I have identified following modules with dead code and will post patches to get rid of it. basctl binfilter comphelper connectivity dbaccess desktop extensions fpicker framework i18npool idl idlc registry rsc sal sc sd sfx2 so3 solenv soltools sot starmath stoc svtools svx sw tools transex3 vcl vos writerperfect xmloff Additionally following modules need further investigation: xmlhelp scripting These modules may contain dead code, but are deemed to be outside the scope of this issue: helpcontent2 readlicense_oo officecfg sdk_oo testtools The command I used to find dead code was: grep -R MAC <modulename> | grep -v localize.sdf | grep -v MACRO | grep -v MACOSX | grep -v MACHINE | grep -v HMAC The results from the above command still needed visual inspection, but most of the false positives are taken care of. This cleanup is important for reducing the code size and to prevent new Mac OS X porters getting confused with System 9 code. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
