To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=4695





------- Additional comments from [EMAIL PROTECTED] Wed Dec 13 08:47:21 -0800 
2006 -------
Hi Maremv,

Implementation is in sc/source/core/tool/interpr1.cxx method
ScInterpreter::ScIndirect(). After the calls to ConvertDoubleRef()
respectively ConvertSingleRef() the else path containing just
SetIllegalArgument() right now must be extended:

- check whether the string matches a defined name, similar to
  sc/source/core/tool/compiler.cxx ScCompiler::IsNamedRange(), but
  without creating a token, instead

- check whether the range data consists of just one single cell or
  a range, other data like multiple ranges or formula fragments are not
  valid. You may use pRangeData->IsReference() for this.

- Relative reference parts need a special handling, and to be Excel
  compatible the relative offsets have to be calculated with a basis of
  A1 and wrapped around the sheet if negative. I suggest to create
  another ScRangeData::IsReference() method that additionally takes
  a ScAddress position (ScInterpreter::aPos member variable), same for
  ScTokenArray::IsReference(), and enhance
  ScTokenArray::ImplGetReference() to take account of an optional
  position address passed in.

I suggest to refrain from trying to handle the external reference case
at this stage, which would unnecessarily complicate things, and let it
be a separate issue instead. However, if you feel confident that could
be accomplished by digging deep into the lcl_ScAddress_Parse_...()
methods of sc/source/core/tool/address.cxx

Please note that to integrate code or data contributed we need a signed
Joint Copyright Assignment form (JCA) filled-out, see
http://contributing.openoffice.org/programming.html#jca
To be able to lookup your name in the list of approved assignments I'd
appreciate if you stated your full name here in this issue.

  Eike


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to