To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=73468
------- Additional comments from [EMAIL PROTECTED] Mon Jan 15 05:11:51 -0800 2007 ------- Sorry, I was in a bit of a hurry yesterday and forgot to include the descriptions of the individual types of patches. So here are the definitions as reported by Colombus, the source code analyzer of the University of Szeged: GEN1007: data member is being initialized by a non-initialized data member (data members in the constructor initializer list are being initialized in the same order as they were declared in the class body) GEN7052: in case of storing the result of a division in a float/double variable, the operands should be casted to float/double to avoid rounding errors GEN7053: long integer literals should be casted to sal_Int32 when participating in an expression whose result's type is sal_Int32 I'm from the Multiracio Ltd. side of the project, so I'll try to get someone from Szeged here to answer questions about these issues. In particular I had my reservations about the casts in GEN7053, and that patch was created in the last minute -- this can be seen as the cause of the missing parentheses. I'll be attaching a fixed patched in a moment. The types of rule violations found in Phase 1 (in 1.1.5) are the following: GEN1004: classes that use dynamically allocated memory should have a copy constructor, an assignment operator and a destructor GEN1020: data members should be initialized GEN7035: switch instructions of integer type should have a 'default' label GEN7051: static variables should be declared as const We would of course like to recreate these patches for 2.1 (and seeing what got fixed already would be valuable feedback), and we would also like to be able to create an online source code monitoring system for OpenOffice.org (like the one currently available for Mozilla at http://frontendart.com/momo.php). I'm not sure about the organization of the project, but let's hope that we can secure the resources to do these. Thank you for looking at our patches. I will be reorganizing them by component affected and refiling them during the week. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
