To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=64086





------- Additional comments from [EMAIL PROTECTED] Mon Jan 15 05:53:03 -0800 
2007 -------
Sorry for not replying earlier.

Thank you for review of file submission, I thought I checked it, but just 
messed it up. 
I will try to answer your questions, and will later attach new attachment which 
will correct these issues.

>hmm.. I'm not sure about that one. Except that it contains a line
>> zsh: command not found: :w
>that would corrupt the file, it

Yes, mistake no. 1:)

>- replaces the typographic quotation marks with the simple ASCII ones,
>  I don't think that was intended.

Yes, this was intended. It is not error in original hr_HR.xml, but this way of 
using quotation marks is more consistent with current Croatian language rules.

>- changes the Time100SecSeparator to a dot whereas the DecimalSeparator
>  is a comma, is that really correct?

Mistake no. 2

> - changes the currency symbol from 'Kn' to 'KN'. If to be changed at
>   all, shouldn't that be 'kn' instead? In the web I encountered both, Kn
>   and kn, but almost never KN. The Croatian National Bank uses 'kn', see
>   http://www.google.com/search?q=site%3Ahnb.hr+kn

Althougk KN is used heavily in Croatia, it is better to change it to lowercase 
kn.
That's mistake no. 3.

> - introduces negative currency amounts placed in parentheses instead of
>   using a leading minus sign, I doubt that is correct.

Mistake no.4, corrected it to previous value.

> - removes the IndexKey element completely (which is replaced by the "zsh
>   command not found"). Anyway, the IndexKey probably needs to be
>   extended from simple ASCII and have the accented letters added used in
>   the Croatian language. A second UnicodeScript value, probably 1,
>   should be added too.

That's also mistake no.1.

> Taking this altogether I wouldn't apply the patch..

And you are right not to do so:)

> Btw, generally a unified diff using the  diff -up  command is much
> preferred over the simple replacement diff, because it makes applying
> a patch much easier in case the file changed in the meantime.

Once again, I'm sorry for giving such a bad patch, I will make a new unified 
diff and submit it here.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to