To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=74213


User cl changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Tue Feb  6 14:18:57 +0000 
2007 -------
CL: the cause of the crash is that in this scenario,
SdDrawDocument::RemoveUnnessesaryMasterPages() is called. This contains code
that if a masterpage is deleted because it is no longer used, the current
visible page is hidden from the document view by calling
SdrDrawView::HideSdrPage(). Since no ShowSdrPage is following we later crash in
GetMenuState() that expects to always have a SdrPageView pointer. This is also
assumed at many other locations.

So the code in RemoveUnnessesaryMasterPages() is wrong since it does not check
if the masterpage that is deleted is really the one that is currently visible. I
changed the code to check that. If the deleted masterpage is also visible, I
hide it and show the first non master slide instead, therefore always having a
valid SdrPageView.

Since this is a regression but the code location that caused this bug is not
changed for a very very very very long time, I suspect that we had some changes
in the view handling that let this bug surface from the deep.

Fixed in cws impress117

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to