To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=74185


User jbu changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Thu Feb 15 19:45:32 +0000 
2007 -------
Hi,

attached is a patch for the wizards projects agains SRC680_m195, which
makes the OOo TableWizard work with the postgresql driver
with version 0.7.4 (will be released soon) or higher. SRC680_m195 is quite old,
but when I saw it correctly, it is the latest version for the relevant files.

The patch changes the following behaviour:

- The wizard now takes into account the type's precision attribute,
  when matching an arbitrary varchar type to a database specific type.
  In postgresql, there are multiple types which are reflected as
  varchar, the one is varchar (which may have an upper limit) and the
  other one is text (which must not have an upper limit).
  The wizard now chooses the varchar type instead of the text type earlier
- A bug within TypeInspector.java was fixed (didnt know myself, that in
  java you can do an boolean assignment within an "if" condition).
- When the wizard itself inserted a new primary key column, it did not
  pass a typename, which lead to an error when creating such tables.

Some problems cannot be solved by design. One problem is, that the tablewizard
chooses concrete database dependent default types for the columns. In case
there are multiple database types for OOo char or Memo fields, it is arbirtrary,
which types are chosen by the wizard. In future OOo versions, the drivers
should expose the default types ... . Currently, the wizard will create bpchar
for char
and xid for Memo fields, which is wrong.

@QA: When the patch is QAed, you should verify, that the table wizard table 
creation
still works as befor with all other database backend supported by OOo.

Bye,

Joerg

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to