To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=75399
User mhu changed the following:
What |Old value |New value
================================================================================
Status|NEW |STARTED
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Apr 2 09:41:44 +0000
2007 -------
Hi Radek,
Thanks for providing this patch. I'm sorry it took more time than expected to
write down my comments.
First of all, I think the patch indeed does what it claims to do (perhaps modulo
some minor platform / compiler issues), and this is good.
There are a couple of points that I think could be solved different, though.
(*) the proposed change is not local to module 'store', but touches a couple
more modules. This is due to an (syntactically incompatible) change to
store's api.
(*) From what I can see, this api change in turn is due (and necessary) to an
(semantically incompatible) change to
(a) the maximum name length (only a single 'OStorePageLongNameData' page)
so that names must in fact be shorter than STORE_MAXIMUM_NAMESIZE=256
characters, and
(b) the reduction in STORE_DEFAULT_PAGESIZE reduces the maximum stream
length (determined by the number of single / double / triple indirect
pages) from the GByte range into the MByte range.
I'm happily taking your proposed change as good input to the very similar change
that I'm currently working on (which does not introduce the above mentioned
semantic changes, and thus does not need an incompatible api change so that it
can stay local to module 'store').
As this patch will not be applied verbatim (as is), I'm changing the issue type
from 'PATCH' to 'ENHANCEMENT', and add the issue to my upcoming cws where our
combined changes will then be integrated.
Thanks,
Matthias
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
